Page MenuHomePhabricator

efl_ui_layout: Fix "theme,changed" callback not being called in legacy widget cases.
AbandonedPublic

Authored by jsuya on Thu, Nov 14, 10:17 PM.

Details

Summary

This problem occurs with patch 7ad8ac.
evas_object_smart_callback_add calls efl_event_callback_priority_add
And When widget is legacy, cb_theme_changed is false.

Test Plan

static void
_changed_cb(void *data, Evas_Object *obj EINA_UNUSED, void *event_info EINA_UNUSED) {

printf("theme changed\n");

}
...
Evas_Object *btn = elm_button_add(parent);
evas_object_smart_callback_add(btn, "theme,changed", _changed_cb, NULL);
elm_object_style_set(btn, "circle");

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14531
Build 9992: arc lint + arc unit
jsuya created this revision.Thu, Nov 14, 10:17 PM
jsuya requested review of this revision.Thu, Nov 14, 10:17 PM
jsuya updated this revision to Diff 26919.

remove empty line

cedric added inline comments.Fri, Nov 15, 9:21 AM
src/lib/elementary/efl_ui_layout.c
2991

What is the reason of the check on priority?

jsuya abandoned this revision.Thu, Nov 21, 3:07 AM

The fix for this issue is replaced by the D10679 patch.