Page MenuHomePhabricator

Revert "efl_ui/layout: selectively inhibit theme,changed event"

Authored by jsuya on Nov 14 2019, 10:52 PM.



This reverts commit 7ad8acc290f078aa9d2bfd32ec15a4e5677ab01f.

When widget is legacy, cb_theme_changed is always false.

Test Plan

static void
_changed_cb(void *data, Evas_Object *obj EINA_UNUSED, void *event_info EINA_UNUSED) {
printf("theme changed\n");
Evas_Object *btn = elm_button_add(parent);
evas_object_smart_callback_add(btn, "theme,changed", _changed_cb, NULL);
elm_object_style_set(btn, "circle");

Diff Detail

rEFL core/efl
No Linters Available
No Unit Test Coverage
Build Status
Buildable 14535
Build 9996: arc lint + arc unit
jsuya created this revision.Nov 14 2019, 10:52 PM
jsuya requested review of this revision.Nov 14 2019, 10:52 PM

Does replacing desc == EFL_CANVAS_GROUP_EVENT_MEMBER_ADDED with the a check if the name of the event is "theme,changed" fix the issue ?

jsuya added a comment.Nov 19 2019, 2:22 AM

Hi @bu5hm4n :)
sorry I don't know how to i get event name in _efl_ui_layout_base_efl_object_event_callback_priority_add function.
Can you tell me more detail?
And most of all I don't know why desc == EFL_CANVAS_GROUP_EVENT_MEMBER_ADDED was added.
7ad8acc290f078aa9d2bfd32ec15a4e5677ab01f I checked this patch but I still don't understand.
So I couldn't find a way to improve this problem and made this revert patch.
I hope @zmike to check this :)

No problem, @zmike is on vacation ... :)

You can get the event name via desc->name where desc is the event description (array[i].desc or desc).

To be completely honest i also do not know why EFL_CANVAS_GROUP_EVENT_MEMBER_ADDED was checked... :/

jsuya added a comment.Nov 25 2019, 6:50 PM

Hi @zmike please check this

zmike added a comment.Nov 26 2019, 6:07 AM

Oops, that's a copy/paste error. Applying the change @bu5hm4n suggested is correct.

zmike requested changes to this revision.Nov 27 2019, 5:57 AM

This is not needed once the series beginning with D10737 is applied.

This revision now requires changes to proceed.Nov 27 2019, 5:57 AM
jsuya abandoned this revision.Nov 27 2019, 11:19 PM