Page MenuHomePhabricator

elementary: reduce events triggered by Efl.Ui.PositionManager.
ClosedPublic

Authored by cedric on Fri, Nov 15, 11:26 AM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Fri, Nov 15, 11:26 AM

I am wondering here. Doesnt that mean that we are not emitting visibility,changed events anymore ? :/

I am wondering here. Doesnt that mean that we are not emitting visibility,changed events anymore ? :/

Good question. I am mimicking here genlist behavior. I am wondering if this would be a problem, especially because if we one day rely on proxy/viewport to move object, the visibility event would be on the proxy and the object would be visible as soon as it is set on a proxy/viewport. So not sure it is an important event to preserve and encourage users to depends on as it force us into a corner on what we can do with this expected behavior.

bu5hm4n accepted this revision.Wed, Nov 20, 11:38 AM

Okay, I am happy with that

This revision is now accepted and ready to land.Wed, Nov 20, 11:38 AM
SanghyeonLee accepted this revision.Tue, Dec 10, 11:21 PM
Closed by commit rEFL2b324779c996: elementary: reduce events triggered by Efl.Ui.PositionManager. (authored by cedric, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyWed, Dec 11, 2:13 AM
This revision was automatically updated to reflect the committed changes.