Page MenuHomePhabricator

Edje: edc text_class applied without font or font_size in style
Needs ReviewPublic

Authored by a.srour on Mon, Nov 18, 7:27 AM.

Details

Summary

This patch fixes the issue described in T8478.

Test Plan

layout.edc

// compile: edje_cc layout.edc
// play: edje_player layout.edj
collections {
    text_classes {
       text_class {
          name: "tc1";
          font: "Sans";
          size: 20;
       }
    }
    styles {
        style {
            name: "style1";
            base: "color=#FFFFFF text_class=tc1";
        }
    }
    group {
        name : "group1";
        parts {
           part {
              name : "tb1";
              type: TEXTBLOCK;
              scale: 1;
              entry_mode: NONE;
              description {
                  state: "default" 0.0;
                  rel1.relative: 0.0 0.0;
                  rel2.relative: 0.5 0.5;
                  text {
                     style: "style1";
                     align: 0.0 0.0;
                     text: "Hello EFL";
                  }
              }
           }
        }
    }
}

Diff Detail

Repository
rEFL core/efl
Branch
arcpatch-D10692
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14566
Build 10015: arc lint + arc unit
a.srour created this revision.Mon, Nov 18, 7:27 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

a.srour requested review of this revision.Mon, Nov 18, 7:27 AM
a.srour edited the summary of this revision. (Show Details)Mon, Nov 18, 7:35 AM
a.srour edited the test plan for this revision. (Show Details)
segfaultxavi requested changes to this revision.Mon, Nov 18, 7:35 AM
segfaultxavi added reviewers: smohanty, ali.alzyod.
segfaultxavi added a subscriber: segfaultxavi.

Can you please explain in the commit message what is the exact problem you are trying to fix, and how are you fixing it?
Otherwise, this is very hard to review.

This revision now requires changes to proceed.Mon, Nov 18, 7:35 AM

Can you please explain in the commit message what is the exact problem you are trying to fix, and how are you fixing it?
Otherwise, this is very hard to review.

Wow Super fast, we were adding a description using web interface :)

segfaultxavi resigned from this revision.Mon, Nov 18, 7:39 AM

Hahaha, I always wondered why you add the description after submitting the patch. What process do you follow?

Hahaha, I always wondered why you add the description after submitting the patch. What process do you follow?

Normally create revision with arcanist, and if the description is long, instead of writing it on the console, we do it in the web interface

ali.alzyod added inline comments.Mon, Nov 18, 7:54 AM
src/lib/edje/edje_textblock_styles.c
198

Why do not we use the same old function

a.srour updated this revision to Diff 26967.Mon, Nov 18, 8:00 AM

Resolve required changes

a.srour updated this revision to Diff 26968.Mon, Nov 18, 8:01 AM

Remove whitespace

a.srour marked an inline comment as done.Mon, Nov 18, 8:01 AM

Resolve required changes

Any update regarding this Diff?