Page MenuHomePhabricator

csharp: Fix CA1815 for generated structs and aliases
ClosedPublic

Authored by lauromoura on Nov 18 2019, 9:08 PM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lauromoura created this revision.Nov 18 2019, 9:08 PM
lauromoura requested review of this revision.Nov 18 2019, 9:08 PM
lauromoura added inline comments.Nov 18 2019, 9:12 PM
src/bin/eolian_mono/eolian/mono/struct_definition.hh
535

This attribute_reorder is a generator that pulls one element from the expression (in this case, a struct_field_def, expanded from struct_.fields by the % operator) and extracts attributes from it (as a tuple) passing to the nested generator expression (the name << "..." << name).

In this case, the -1 represents the original element (the struct_field_def), so attribute_reorder<-1, -1> means the sub generator will receive it twice.

I know, I know, we should have some introductory document to the generator scheme... :)

brunobelo accepted this revision.Nov 19 2019, 5:24 AM
This revision is now accepted and ready to land.Nov 19 2019, 5:24 AM
This revision was automatically updated to reflect the committed changes.