Depends on D10607
Original Material: https://www.enlightenment.org/_legacy_embed/evas_textblock_style_page.html
Details
Details
Diff Detail
Diff Detail
- Repository
- rEFL core/efl
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/
Comment Actions
Needs rebasing to latest master.
In the comments I request a lot of information and I understand you might not know it. But we must provide it to our users, so we must dig that info up. I assume you know better than me because you have been working on the code, but if it's not the case, I can commandeer the revision.
Please understand that if we are providing a wrapper around fontconfig to isolate the user from it, then we must provide this info or point the user to the relevant fontconfig help page.
When we are done with the comments I can take over and work on the formatting. This is a HUGE piece of documentation which must be formatted correctly to be easily understandable (lists, headers, etc). Unfortunately these docs get converted to different formats so formatting is a hard problem.
| src/lib/evas/canvas/efl_canvas_text.eo | ||
|---|---|---|
| 85 | I think I prefer attribute rather than command. These do not look like commands to me. | |
| 91 | Shouldn't this be "font_fallbacks"? Notice the all-lowercase, the underscore and the ending s. Please double-check that all these strings are correct. | |
| 132 | What are the available fonts? Is there a command the user can run to find out this list? | |
| 137 | It's "fallbacks" in plural, so I guess this accepts a list? in what format? | |
| 144 | What is this "object"? | |
| 185 | Is this the full language name ("English)" or some abbreviation ("En")? Does it accept variations ("En_US")? | |
| 199 | Is there a list somewhere with all the available color names? | |
| 279 | What are the units of these numbers? | |
| 287 | What are the units of these numbers? | |
| 310 | And what is "backing"? | |
| 316 | Can styles by merged? I mean can I enable "shadow" and "glow" at the same time? | |
| 342 | Unit? | |
| 346 | What is the size of a line of text? The distance between to lines? The width of the stroke? Also, what are the units? | |
| 351 | A percentage of what? | |
| 356 | What is a line gap? What are the units of this number? | |
| 361 | Percentage of what? | |
| 366 | Can we remove this if it does nothing? | |
| 370 | What is this and a percentage of what? | |
| 387 | Units? | |
| 391 | Units? | |
Comment Actions
update
| src/lib/evas/canvas/efl_canvas_text.eo | ||
|---|---|---|
| 91 | This is just a description of what attributes we have, there are no underscores. | |
| 132 | Using EFL Bindings, we do not have such a feature yet. In legacy, user could use evas_font_path_global_list | |
| 316 | As far as I know it can not. @woohyun ? | |
| 346 | It is no lineWidth, it is line-height (In font metric Ascent+Descent), this will not change font size but change Ascent, Descent of the line. | |
| 351 | line ascent and descent | |
Comment Actions
Thanks for the update. Just a few more questions and I'll take it from here (in a different patch).
| src/lib/evas/canvas/efl_canvas_text.eo | ||
|---|---|---|
| 144 | Ha ha, very funny. I still don't know what "source" is. Is it a file path? Is it a font name? | |
| 185 | OK, from the example, I'll assume "language" must be a 2-letter ISO 639-1 language code. | |
| 310 | If the background color is disabled, will the background be transparent? | |
| 370 | Sorry, I still don't understand. | |
| src/lib/evas/canvas/efl_canvas_text.eo | ||
|---|---|---|
| 310 | Yes | |
| 370 | Line fill is interested only about the height of the canvas. linefill=50% means the line will cover 50% of the canvas space (font size will not change but empty space top and bottom of line will increase ), In other words, | |
Comment Actions
OK! Looks like it contains all the information now. I'll submit another patch later on.
Thanks for your patience!