Page MenuHomePhabricator

efl_ui/layout: fix typo in theme,changed event checking and fix this event
ClosedPublic

Authored by zmike on Tue, Nov 26, 8:05 AM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Tue, Nov 26, 8:05 AM
zmike requested review of this revision.Tue, Nov 26, 8:06 AM
jsuya added a comment.Wed, Nov 27, 1:26 AM

Hi This does not work in legacy cases.

static void
_changed_cb(void *data, Evas_Object *obj EINA_UNUSED, void *event_info EINA_UNUSED) {
printf("theme changed\n");
}
...
Evas_Object *btn = elm_button_add(parent);
evas_object_smart_callback_add(btn, "theme,changed", _changed_cb, NULL);
elm_object_style_set(btn, "anchor");

how about this? desc == EFL_UI_LAYOUT_EVENT_THEME_CHANGED) || !strncmp(SIG_THEME_CHANGED, desc->name, strlen(SIG_THEME_CHANGED))

zmike added a comment.Wed, Nov 27, 5:07 AM

Ah, I see what you're getting at. I'll handle this...

bu5hm4n accepted this revision.Wed, Dec 4, 7:33 AM
This revision is now accepted and ready to land.Wed, Dec 4, 7:33 AM
Closed by commit rEFLe9281cf124b2: efl_ui/layout: fix typo in theme,changed event checking and fix this event (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyWed, Dec 4, 7:49 AM
This revision was automatically updated to reflect the committed changes.