Page MenuHomePhabricator

efl_ui/layout: fix multiple emissions of theme,changed during construction
ClosedPublic

Authored by zmike on Tue, Nov 26, 8:06 AM.

Details

Summary

in the case where a layout object was created and had a theme manually set
with efl_ui_layout_theme_set() during construction, the layout would then
call theme_apply() a second time internally during finalize which, if the
theme has not changed (as can only be the case if this flag is unset),
results in a repeated theme_apply for the existing theme

@fix
Depends on D10737

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Tue, Nov 26, 8:06 AM
zmike requested review of this revision.Tue, Nov 26, 8:06 AM
bu5hm4n accepted this revision.Wed, Dec 4, 7:34 AM

I am like 100% sure this will cause bugs, but i cannot tell you why ...

This revision is now accepted and ready to land.Wed, Dec 4, 7:34 AM
Closed by commit rEFL3f7a63149a74: efl_ui/layout: fix multiple emissions of theme,changed during construction (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyWed, Dec 4, 7:49 AM
This revision was automatically updated to reflect the committed changes.