Page MenuHomePhabricator

tests/ecore_wl2: Add test for ecore_wl2_window_aux_hint functions
Needs ReviewPublic

Authored by CHAN on Wed, Nov 27, 11:16 PM.

Details

Summary

tests/ecore_wl2: Add test for ecore_wl2_window_aux_hint functions

ref T8016

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14721
Build 10142: arc lint + arc unit
CHAN created this revision.Wed, Nov 27, 11:16 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

CHAN requested review of this revision.Wed, Nov 27, 11:16 PM
CHAN edited the summary of this revision. (Show Details)Wed, Nov 27, 11:18 PM
CHAN added a reviewer: devilhorns.

@devilhorns hello.

I expected that when i called ecore_wl2_window_aux_hint_add() after that

ecore_wl2_window_aux_hints_supported_get() will return list that includes added value.

But it's not there in list.

Um... any idea to create TC for this?

window aux hints is something that is only going to be supported using Enlightenment as the wayland compositor, that is why the wl2_window_aux_hints_supported_get function is only called when Enlightenment is the compositor. (getenv("E_START")). The actual test code you wrote here looks fine.

CHAN added a comment.Mon, Dec 9, 12:14 AM

@devilhorns hello.

I tested it on Enligntenment actually.

When i called ecore_wl2_window_aux_hint_add().
I expected that the _aux_hints_supported_aux_hints() will be called and it will updated win->supported_aux_hints list.
But, _aux_hints_supported_aux_hints() is not called for this case.

Any point to check? or any suggestion about it?

@CHAN To be honest, I am unsure. Aux Hints support was something that mike added. I will take a look through the code and see if I can find out how it is meant to be used.