Page MenuHomePhabricator

efl_ui_spotlight: do not inherit from layout anymore
ClosedPublic

Authored by bu5hm4n on Thu, Nov 28, 5:28 AM.

Details

Summary

before we inherited from layout, however the theme of the layout was
basically just the event part, and the holder part for the indicator.
The indicator part is going to be refactored into something else
anyways, since the indicator should be useable on other widgets as well.
Which means, only the event part is left, which is only used by the
scroller spotlight manager, (and now moved there).

With the move from this away we are saving round about 0.2KB of pure
edje accounting. Additionally, we are saving in perf 4% that is spend in
_efl_canvas_layout_efl_gfx_entity_size_set, which also makes this less
CPU intensive when resizing (Or even just starting is also enough).

ref T7991
Depends on D10764

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Thu, Nov 28, 5:28 AM
bu5hm4n requested review of this revision.Thu, Nov 28, 5:28 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, Dec 2, 9:32 AM
Closed by commit rEFL703381655449: efl_ui_spotlight: do not inherit from layout anymore (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain Why
This revision was automatically updated to reflect the committed changes.