Page MenuHomePhabricator

edje_entry: converting plain_text to '*' using unicode units.
ClosedPublic

Authored by bowonryu on Dec 3 2019, 9:22 PM.

Details

Summary

When converting plain_text to '*' in retrieve_surrounding_cb,
always convert it to '*' in 1 byte unit.

For example,
2 byte character is converted to "* *"
and 3 byte character is converted to "* * *"

However, this does not match the number of '*' printed in the entry.
Because, '*' in the entry is printed according to number of unicode characters.

This patch converts plain_text into unicode units
when converting plain_text to '*'

Test Plan

N/A

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bowonryu created this revision.Dec 3 2019, 9:22 PM
bowonryu requested review of this revision.Dec 3 2019, 9:22 PM
bowonryu edited the summary of this revision. (Show Details)Dec 3 2019, 9:38 PM
bowonryu edited the summary of this revision. (Show Details)Dec 3 2019, 9:40 PM
woohyun accepted this revision.Dec 4 2019, 12:09 AM

I tested with Ecore IMF in Tizen - and verified it worked fine.

This revision is now accepted and ready to land.Dec 4 2019, 12:09 AM
This revision was automatically updated to reflect the committed changes.