Page MenuHomePhabricator

Efl.Canvas.Text rename into Efl.Canvas.Textblock
ClosedPublic

Authored by ali.alzyod on Dec 5 2019, 3:04 AM.

Details

Summary

Efl.Canvas.Text renamed into Efl.Canvas.Textblock
Efl.Canvas.Text_Factory renamed into Efl.Canvas.Textblock_Factory

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ali.alzyod created this revision.Dec 5 2019, 3:04 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Dec 5 2019, 3:04 AM
ali.alzyod retitled this revision from efl_text_attribute_factory: update documention to efl_canvas_Text rename into efl_canvas_textblock.Dec 5 2019, 3:05 AM
ali.alzyod edited the summary of this revision. (Show Details)
ali.alzyod retitled this revision from efl_canvas_Text rename into efl_canvas_textblock to Efl.Canvas.Text rename into Efl.Canvas.Textblock.
ali.alzyod edited the summary of this revision. (Show Details)
segfaultxavi requested changes to this revision.Dec 5 2019, 7:24 AM

Wait a minute. Is this changing the LEGACY API too?

NEWS
388

You probably don't want to change this :)

This revision now requires changes to proceed.Dec 5 2019, 7:24 AM

Wait a minute. Is this changing the LEGACY API too?

Is this related to legacy?

NEWS
388

Why ?

Yes, you are modifying Legacy API symbol names, which will break legacy applications.
I marked one with an inline comment, as an example.
Just build and install your patch and then try to compile Enlightenment or Terminology to see what I mean.

Legacy methods must keep the same names, but they are free to call the renamed Unified methods.

NEWS
388

Because this is HISTORY, you cannot modify this file, only add things.
Version 1.20 of EFL mentions Efl.Canvas.Text.Factory, which you are now renaming, right, but this is how it was called back then.

src/lib/evas/canvas/efl_canvas_textblock_eo.legacy.h
35

This method is EAPI so it is public.
This method does not start with efl_, therefore it is LEGACY.

Legacy applications relying on symbol evas_object_textblock_visible_range_get will not work now.

ali.alzyod added inline comments.Dec 5 2019, 8:17 AM
NEWS
388

Ooops, sorry
I rename all at once

src/lib/evas/canvas/efl_canvas_textblock_eo.legacy.h
35

Hmmm

There is no Efl_Canvas_Text, it is called Efl_Canvas_Textblock now.

And in legacy there are no Efl_xx classes, this header used internal.

segfaultxavi accepted this revision.Dec 5 2019, 8:48 AM

Builds and passes tests. Nothing to complain.

src/lib/evas/canvas/efl_canvas_textblock_eo.legacy.h
35

Ahhh, my bad. I misread the patch. I thought you were renaming the method NAME. Now I see you renamed one of the parameters. No problem then, sorry.

This revision is now accepted and ready to land.Dec 5 2019, 8:48 AM
This revision was automatically updated to reflect the committed changes.