Efl.Canvas.Text rename into Efl.Canvas.Textblock
ClosedPublic
Actions

Authored by ali.alzyod on Dec 5 2019, 3:04 AM.

Details

Reviewers

woohyun
segfaultxavi
zmike
bu5hm4n
YOhoho

Commits

rEFL621d2cdecf8f: Efl.Canvas.Text rename into Efl.Canvas.Textblock

Summary

Efl.Canvas.Text renamed into Efl.Canvas.Textblock
Efl.Canvas.Text_Factory renamed into Efl.Canvas.Textblock_Factory

Diff Detail

Repository

rEFL core/efl

Branch

arcpatch-D10808

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14894
Build 10246: arc lint + arc unit

ali.alzyod created this revision.Dec 5 2019, 3:04 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Dec 5 2019, 3:04 AM

Harbormaster completed remote builds in B14818: Diff 27333.Dec 5 2019, 3:04 AM

ali.alzyod retitled this revision from efl_text_attribute_factory: update documention to efl_canvas_Text rename into efl_canvas_textblock.Dec 5 2019, 3:05 AM

ali.alzyod edited the summary of this revision. (Show Details)

ali.alzyod added reviewers: woohyun, segfaultxavi, zmike, bu5hm4n.

ali.alzyod mentioned this in T8093: Name conflict between class and property.

ali.alzyod added a reviewer: YOhoho.Dec 5 2019, 3:17 AM

ali.alzyod retitled this revision from efl_canvas_Text rename into efl_canvas_textblock to Efl.Canvas.Text rename into Efl.Canvas.Textblock.

ali.alzyod edited the summary of this revision. (Show Details)

Wait a minute. Is this changing the LEGACY API too?

NEWS
388	You probably don't want to change this :)

This revision now requires changes to proceed.Dec 5 2019, 7:24 AM

In D10808#203133, @segfaultxavi wrote:

Wait a minute. Is this changing the LEGACY API too?

Is this related to legacy?

NEWS
388	Why ?

Yes, you are modifying Legacy API symbol names, which will break legacy applications.
I marked one with an inline comment, as an example.
Just build and install your patch and then try to compile Enlightenment or Terminology to see what I mean.

Legacy methods must keep the same names, but they are free to call the renamed Unified methods.

NEWS
388	Because this is HISTORY, you cannot modify this file, only add things. Version 1.20 of EFL mentions Efl.Canvas.Text.Factory, which you are now renaming, right, but this is how it was called back then.
src/lib/evas/canvas/efl_canvas_textblock_eo.legacy.h
35	This method is `EAPI` so it is public. This method does not start with `efl_`, therefore it is LEGACY. Legacy applications relying on symbol `evas_object_textblock_visible_range_get` will not work now.

ali.alzyod added inline comments.Dec 5 2019, 8:17 AM

NEWS
388	Ooops, sorry I rename all at once
src/lib/evas/canvas/efl_canvas_textblock_eo.legacy.h
35	Hmmm There is no Efl_Canvas_Text, it is called Efl_Canvas_Textblock now. And in legacy there are no Efl_xx classes, this header used internal.

Builds and passes tests. Nothing to complain.

src/lib/evas/canvas/efl_canvas_textblock_eo.legacy.h
35	Ahhh, my bad. I misread the patch. I thought you were renaming the method NAME. Now I see you renamed one of the parameters. No problem then, sorry.

This revision is now accepted and ready to land.Dec 5 2019, 8:48 AM

rebase

Harbormaster completed remote builds in B14894: Diff 27434.Dec 10 2019, 12:17 AM

rebase

Harbormaster completed remote builds in B14895: Diff 27435.Dec 10 2019, 12:37 AM

Closed by commit rEFL621d2cdecf8f: Efl.Canvas.Text rename into Efl.Canvas.Textblock (authored by ali.alzyod, committed by woohyun). · Explain WhyDec 10 2019, 1:32 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		NEWS (2 lines)
M		src/bin/elementary/test_gfx_filters.c (2 lines)
M		src/lib/edje/edje_textblock.c (44 lines)
M		src/lib/elementary/efl_ui_internal_text_interactive.c (50 lines)
M		src/lib/elementary/efl_ui_internal_text_interactive.eo (2 lines)
M		src/lib/elementary/efl_ui_internal_text_scroller.c (6 lines)
M		src/lib/elementary/efl_ui_internal_text_scroller.eo (6 lines)
M		src/lib/elementary/efl_ui_text.c (24 lines)
M		src/lib/elementary/efl_ui_text.eo (2 lines)
M		src/lib/elementary/efl_ui_text_factory_emoticons.c (2 lines)
M		src/lib/elementary/efl_ui_text_factory_emoticons.eo (4 lines)
M		src/lib/elementary/efl_ui_text_factory_fallback.c (8 lines)
M		src/lib/elementary/efl_ui_text_factory_fallback.eo (4 lines)
M		src/lib/elementary/efl_ui_text_factory_images.c (2 lines)
M		src/lib/elementary/efl_ui_text_factory_images.eo (4 lines)
M		src/lib/evas/Efl_Canvas.h (4 lines)
M		src/lib/evas/Evas_Eo.h (6 lines)
V		src/lib/evas/canvas/{efl_canvas_text.eo → efl_canvas_textblock.eo}
V		src/lib/evas/canvas/{efl_canvas_text_eo.legacy.h → efl_canvas_textblock_eo.legacy.h}
D	M	src/lib/evas/canvas/efl_canvas_text_eo.legacy.c (72 lines)
V		src/lib/evas/canvas/{efl_canvas_text_factory.eo → efl_canvas_textblock_factory.eo}
V		src/lib/evas/canvas/{efl_canvas_text_internal.h → efl_canvas_textblock_internal.h}
V		src/lib/evas/canvas/{efl_canvas_textblock.eo ← efl_canvas_text.eo} (2 lines)
V		src/lib/evas/canvas/{efl_canvas_textblock_eo.legacy.h ← efl_canvas_text_eo.legacy.h} (36 lines)
A	M	src/lib/evas/canvas/efl_canvas_textblock_eo.legacy.c (72 lines)
V		src/lib/evas/canvas/{efl_canvas_textblock_factory.eo ← efl_canvas_text_factory.eo} (2 lines)
V		src/lib/evas/canvas/{efl_canvas_textblock_internal.h ← efl_canvas_text_internal.h} (24 lines)
M		src/lib/evas/canvas/efl_text_attribute_factory.c (4 lines)
M		src/lib/evas/canvas/efl_text_attribute_factory.eo (4 lines)
M		src/lib/evas/canvas/efl_text_cursor.c (4 lines)
M		src/lib/evas/canvas/evas_object_textblock.c (600 lines)
M		src/lib/evas/canvas/evas_textblock_hyphenation.x (4 lines)
M		src/lib/evas/canvas/evas_textblock_legacy.h (12 lines)
M		src/lib/evas/canvas/meson.build (6 lines)
M		src/tests/evas/evas_test_textblock.c (102 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	27333	d8fb0b0		Dec 5 2019, 3:04 AM	★	★
Diff 2	27434	f793939	rebase	Dec 10 2019, 12:17 AM	★	★
Diff 3	27435	f793939	rebase	Dec 10 2019, 12:36 AM	★	★
Diff 4	27438	f793939	rEFL621d2cdecf8f53526f1e8ca427bf815086768a28	Dec 10 2019, 12:39 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
6f1084aaeaad	921849e58dc3	f793939315b3	Ali Alzyod	Efl.Canvas.Text rename into Efl.Canvas.Textblock (Show More…)	Dec 10 2019, 12:11 AM

Efl.Canvas.Text rename into Efl.Canvas.TextblockClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 27434

NEWS

src/bin/elementary/test_gfx_filters.c

src/lib/edje/edje_textblock.c

src/lib/elementary/efl_ui_internal_text_interactive.c

src/lib/elementary/efl_ui_internal_text_interactive.eo

src/lib/elementary/efl_ui_internal_text_scroller.c

src/lib/elementary/efl_ui_internal_text_scroller.eo

src/lib/elementary/efl_ui_text.c

src/lib/elementary/efl_ui_text.eo

src/lib/elementary/efl_ui_text_factory_emoticons.c

src/lib/elementary/efl_ui_text_factory_emoticons.eo

src/lib/elementary/efl_ui_text_factory_fallback.c

src/lib/elementary/efl_ui_text_factory_fallback.eo

src/lib/elementary/efl_ui_text_factory_images.c

src/lib/elementary/efl_ui_text_factory_images.eo

src/lib/evas/Efl_Canvas.h

src/lib/evas/Evas_Eo.h

src/lib/evas/canvas/efl_canvas_text.eo

src/lib/evas/canvas/efl_canvas_text_eo.legacy.h

src/lib/evas/canvas/efl_canvas_text_eo.legacy.c

src/lib/evas/canvas/efl_canvas_text_factory.eo

src/lib/evas/canvas/efl_canvas_text_internal.h

src/lib/evas/canvas/efl_canvas_textblock.eo

src/lib/evas/canvas/efl_canvas_textblock_eo.legacy.h

src/lib/evas/canvas/efl_canvas_textblock_eo.legacy.c

src/lib/evas/canvas/efl_canvas_textblock_factory.eo

src/lib/evas/canvas/efl_canvas_textblock_internal.h

src/lib/evas/canvas/efl_text_attribute_factory.c

src/lib/evas/canvas/efl_text_attribute_factory.eo

src/lib/evas/canvas/efl_text_cursor.c

src/lib/evas/canvas/evas_object_textblock.c

src/lib/evas/canvas/evas_textblock_hyphenation.x

src/lib/evas/canvas/evas_textblock_legacy.h

src/lib/evas/canvas/meson.build

src/tests/evas/evas_test_textblock.c

Efl.Canvas.Text rename into Efl.Canvas.Textblock
ClosedPublic
Actions

Revision Contents
Changeset List