Page MenuHomePhabricator

efl.ui.text: rename to efl.ui.textbox
ClosedPublic

Authored by ali.alzyod on Dec 9 2019, 9:39 AM.

Details

Summary

This patch will rename efl.ui.text into efl.ui.textbox

Effected classes:

  • efl.ui.text_async : efl.ui.textbox_async
  • efl.ui.text_editable : efl.ui.textbox_editable will be removed anyway

Needs consider Classes:

  • efl.ui.text_part
  • efl.ui.text_factory.Emoticons
  • efl.ui.text_factory.Fallback
  • efl.ui.text_factory.Images

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ali.alzyod created this revision.Dec 9 2019, 9:39 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Dec 9 2019, 9:39 AM
ali.alzyod added inline comments.Dec 9 2019, 9:42 AM
src/lib/elementary/efl_ui_textbox.c
3710–3738

This Macro does not work anymore

3720

This Macro does not work anymore

3730

This Macro does not work anymore

ali.alzyod edited the summary of this revision. (Show Details)Dec 9 2019, 9:49 AM
ali.alzyod updated this revision to Diff 27443.Dec 10 2019, 4:02 AM
ali.alzyod edited the summary of this revision. (Show Details)

rebase

ali.alzyod updated this revision to Diff 27444.Dec 10 2019, 4:05 AM

keep histroy

ali.alzyod updated this revision to Diff 27445.Dec 10 2019, 4:06 AM

keep histroy

woohyun accepted this revision.Dec 10 2019, 4:40 PM

Based on the discussion of T8093, this patch looks ok :)

This revision is now accepted and ready to land.Dec 10 2019, 4:40 PM
This revision was automatically updated to reflect the committed changes.