Page MenuHomePhabricator

efl_ui : stablized factory classes.
ClosedPublic

Authored by SanghyeonLee on Dec 10 2019, 10:56 PM.

Details

Summary

for mvvm publizing,
caching factory and layout factory need to be out of beta.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
SanghyeonLee created this revision.Dec 10 2019, 10:56 PM
SanghyeonLee requested review of this revision.Dec 10 2019, 10:56 PM

are there any chance to change this class name or method?

are there any chance to change this class name or method?

Which class and which method do you want to change? Why?
We can still rename them, sure, but we need to discuss it.

no, I don't want to :) I'm just asking any possibility cause I hope it would not.
I think we got an agreement that most of mvvm infrastructure is firmed,
so I want to move forward :)

Ah, OK. Let's ask @cedric then :)

Ah, OK. Let's ask @cedric then :)

I am fine with the feature and name, but I prefer someone else to vouch on the name.

Names are perfect. We already discussed them to tears :)

Looks like this is ready then!

cedric accepted this revision.Dec 13 2019, 7:57 AM
This revision is now accepted and ready to land.Dec 13 2019, 7:57 AM
This revision was automatically updated to reflect the committed changes.