Page MenuHomePhabricator

examples: js: remove unused variable in elementary twitter js example
AbandonedPublic

Authored by stefan_schmidt on Dec 16 2019, 5:27 AM.

Details

Reviewers
felipealmeida
Summary

This is not used anywhere in the code after assignment.

Reported-By: https://lgtm.com/projects/g/Enlightenment/efl

Diff Detail

Repository
rEFL core/efl
Branch
lgtm-fixes
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 14971
stefan_schmidt created this revision.Dec 16 2019, 5:27 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

stefan_schmidt requested review of this revision.Dec 16 2019, 5:27 AM
ProhtMeyhet added inline comments.
src/examples/elementary/twitter_example_01.js
54

Shouldn't this placeholder be updated as well, then?

@ProhtMeyhet thanks for pointing this out! This should actually be fixed the other way around. I did not realise below screen_name was used twice instead of user_name which should be used.
Will fix tomorrow.

Fixed but Phab did not allow me to update this differential. Seems the change was to different to track it for the tool.
Uploaded as https://phab.enlightenment.org/D10934 again

stefan_schmidt abandoned this revision.Dec 20 2019, 12:39 AM