Page MenuHomePhabricator

efl_canvas_textblock: allow style_apply with wrap=none
ClosedPublic

Authored by ali.alzyod on Dec 16 2019, 8:07 AM.

Details

Summary

1- passing style_apply("wrap=none") had no effect previously, and now disable wraping
2- style_all_get() by default return "wrap=word", but now return "wrap=none"

refer to T8523

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ali.alzyod created this revision.Dec 16 2019, 8:07 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Dec 16 2019, 8:07 AM
ali.alzyod updated this revision to Diff 27574.Dec 16 2019, 8:30 AM

update tests for default value

segfaultxavi requested changes to this revision.Dec 16 2019, 8:30 AM
segfaultxavi added a subscriber: segfaultxavi.

Awesome! this fixes the wrap problems. Builds and passes tests.

Please add a meaningful commit message and update the documentation. I suggest you make this patch depend on D10873 and work on top of that documentation.

This revision now requires changes to proceed.Dec 16 2019, 8:30 AM
ali.alzyod edited the summary of this revision. (Show Details)Dec 16 2019, 8:30 AM
ali.alzyod added reviewers: woohyun, cedric.
ali.alzyod edited the summary of this revision. (Show Details)

Hahaha, we crossed our reviews again. To avoid this, I suggest you submit your diffs when they are complete.

ali.alzyod updated this revision to Diff 27575.Dec 16 2019, 8:34 AM

update documentation

ali.alzyod retitled this revision from efl_canvas_textblock: wrap style_apply to efl_canvas_textblock: allow style_apply with wrap=none.Dec 16 2019, 8:35 AM

Please add a meaningful commit message and update the documentation. I suggest you make this patch depend on D10873 and work on top of that documentation.

this is independent of D10873 (please correct me if I am wrong).

Please add a meaningful commit message and update the documentation. I suggest you make this patch depend on D10873 and work on top of that documentation.

this is independent of D10873 (please correct me if I am wrong).

Sorry I forget you updated style_apply documentation

segfaultxavi accepted this revision.Dec 16 2019, 10:09 AM

It's OK, I'll rebase D10873.

This revision is now accepted and ready to land.Dec 16 2019, 10:09 AM
This revision was automatically updated to reflect the committed changes.