Page MenuHomePhabricator

elm : add del_intercept exception in elm_widget_item_invalidate to provide delete animation.
Needs ReviewPublic

Authored by SanghyeonLee on Dec 18 2019, 2:34 AM.

Details

Summary

some item widget require specific animation of deletion process.
previously del_pre_hook callback can handle this process by return type,
but after changing del_pre_hook return type, item cannot intercept
deletion process for adding animation.

here my suggestion for delete animation is,
set efl_del_intercept in animation required case,
to avoid edje view object elimination.

each item widget has to call view_clear function after all animation processed.

Test Plan

tested with few genlist deletion process changes(adding 1 sec timer of deletion).
clear case can occur the infinite loop,
so carefully control the intercept on deletion.

to test this,
please apply upon elm_genlist.c file.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15011
Build 10340: arc lint + arc unit
SanghyeonLee created this revision.Dec 18 2019, 2:34 AM
SanghyeonLee requested review of this revision.Dec 18 2019, 2:34 AM
SanghyeonLee edited the test plan for this revision. (Show Details)Dec 18 2019, 2:42 AM

change item->eo_obj to eo_item.

That example has way more code than this patch :-) Could you add it as an additional patch to elementary_test?

SanghyeonLee added a comment.EditedDec 19 2019, 7:15 PM

I'm not sure it can doable in app side level as _elm_widget_item_view_clear is elementary private function and all deletion process in genlist is also internal.
hmm need to think about the way of doing this again as application can intercept the deletion also...