Page MenuHomePhabricator

eina_hash: Move hash_free_cb to avoid memory leak.
ClosedPublic

Authored by CHAN on Dec 19 2019, 1:43 AM.

Details

Summary

Call hash_free_cb after finish deletion.

ref T8530

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
CHAN created this revision.Dec 19 2019, 1:43 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

CHAN requested review of this revision.Dec 19 2019, 1:43 AM
CHAN edited the summary of this revision. (Show Details)Dec 19 2019, 1:44 AM
CHAN added reviewers: cedric, Hermet, smohanty.
CHAN edited the summary of this revision. (Show Details)

Looks reasonable. though it might occur the compatibility break since the logic sequence can be changed by this. We hope it's very rare.
@cedric ?

cedric accepted this revision.Dec 19 2019, 3:43 PM

Make sense.

This revision is now accepted and ready to land.Dec 19 2019, 3:43 PM
Closed by commit rEFLa2084ba22eb7: eina_hash: Move hash_free_cb to avoid memory leak. (authored by Woochanlee <wc0917.lee@samsung.com>, committed by cedric). · Explain WhyDec 19 2019, 3:48 PM
This revision was automatically updated to reflect the committed changes.