Page MenuHomePhabricator

efl.ui.textbox: rename _disabled properties into _enabled
ClosedPublic

Authored by ali.alzyod on Dec 19 2019, 3:43 AM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ali.alzyod created this revision.Dec 19 2019, 3:43 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Dec 19 2019, 3:43 AM
segfaultxavi requested changes to this revision.Dec 20 2019, 3:32 AM

Just two nitpicks...

src/lib/elementary/efl_ui_textbox.c
105

I would rename this to sel_handler_enabled, for consistency with the property..
The default value set at the constructor would need to change then (and all other uses of it).

113

I know this is a bit unrelated to this patch, but this should probably be context_menu_enabled too, for consistency, and for clarity.

This revision now requires changes to proceed.Dec 20 2019, 3:32 AM
ali.alzyod marked 2 inline comments as done.Dec 20 2019, 4:01 AM
segfaultxavi accepted this revision.Dec 20 2019, 5:09 AM

Thanks a lot for putting up with my comments...
The code looks simpler now, doesn't it? :D

This revision is now accepted and ready to land.Dec 20 2019, 5:09 AM
This revision was automatically updated to reflect the committed changes.