Page MenuHomePhabricator
Differential D10923

efl.ui.textbox: rename _disabled properties into _enabled
ClosedPublic
Actions

Authored by ali.alzyod on Dec 19 2019, 3:43 AM.

Details

Reviewers
segfaultxavi
woohyun
bu5hm4n
Maniphest Tasks
T8522: Efl.Ui.Textbox class
Commits
rEFLb9818f566cca: efl.ui.textbox: rename _disabled properties into _enabled

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ali.alzyod created this revision.Dec 19 2019, 3:43 AM
Herald added a project: efl. · View Herald TranscriptDec 19 2019, 3:43 AM
Herald added subscribers: committers, reviewers, cedric. · View Herald Transcript

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Dec 19 2019, 3:43 AM
segfaultxavi requested changes to this revision.Dec 20 2019, 3:32 AM

Just two nitpicks...

src/lib/elementary/efl_ui_textbox.c
105

I would rename this to sel_handler_enabled, for consistency with the property..
The default value set at the constructor would need to change then (and all other uses of it).

113

I know this is a bit unrelated to this patch, but this should probably be context_menu_enabled too, for consistency, and for clarity.

This revision now requires changes to proceed.Dec 20 2019, 3:32 AM
ali.alzyod marked 2 inline comments as done.Dec 20 2019, 4:01 AM
segfaultxavi accepted this revision.Dec 20 2019, 5:09 AM

Thanks a lot for putting up with my comments...
The code looks simpler now, doesn't it? :D

This revision is now accepted and ready to land.Dec 20 2019, 5:09 AM
Closed by commit rEFLb9818f566cca: efl.ui.textbox: rename _disabled properties into _enabled (authored by ali.alzyod, committed by segfaultxavi). · Explain WhyDec 20 2019, 5:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27723

View Options

src/lib/elementary/efl_ui_clock.c

Loading...
View Options

src/lib/elementary/efl_ui_textbox.c

Loading...
View Options

src/lib/elementary/efl_ui_textbox.eo

Loading...