Mhm, this needs more "things" i think.

• grid pm still returns -1
• list pm still returns -1
• collection still uses unsigned int
• collection_view still checks for id < 0.

In general, i don't understand why this has to be unsigned...

In D10927#205781, @bu5hm4n wrote:

Mhm, this needs more "things" i think.

• grid pm still returns -1
• list pm still returns -1
• collection still uses unsigned int
• collection_view still checks for id < 0.

Need fixing. Will look at them.

In general, i don't understand why this has to be unsigned...

The unsigned int is the upper limit of the maximum amount of information you can carry in a model. For example your facebook or twitter history is limited to that much forever. The higher limit, we build in now, is I would think the better for the future.

In D10927#205791, @cedric wrote:

In D10927#205781, @bu5hm4n wrote:

Mhm, this needs more "things" i think.

• grid pm still returns -1
• list pm still returns -1
• collection still uses unsigned int
• collection_view still checks for id < 0.

Need fixing. Will look at them.

In general, i don't understand why this has to be unsigned...

The unsigned int is the upper limit of the maximum amount of information you can carry in a model. For example your facebook or twitter history is limited to that much forever. The higher limit, we build in now, is I would think the better for the future.

Mhm, but then we already have a problem, you can have at MAX INT_MAX items in a collection, as the index in item is a signed int.

In D10927#206183, @bu5hm4n wrote:

Mhm, but then we already have a problem, you can have at MAX INT_MAX items in a collection, as the index in item is a signed int.

Collection is not really a problem here as it will never be possible in term of performance to reach even close to INT_MAX (If we reach on a modern PC SHORT_MAX as a limit, I will be happy). In the case of CollectionView, this is still a possibly doable goal.

In D10927#206187, @cedric wrote:

In D10927#206183, @bu5hm4n wrote:

Mhm, but then we already have a problem, you can have at MAX INT_MAX items in a collection, as the index in item is a signed int.

Collection is not really a problem here as it will never be possible in term of performance to reach even close to INT_MAX (If we reach on a modern PC SHORT_MAX as a limit, I will be happy). In the case of CollectionView, this is still a possibly doable goal.

No no, item is the problem. And we use item in CV as well.
And the index in a item is int.

In D10927#206188, @bu5hm4n wrote:

No no, item is the problem. And we use item in CV as well.
And the index in a item is int.

Oh dang, why! I didn't even know we had that there... CV is not using it nor filling it properly I would bet.

In D10927#206189, @cedric wrote:

In D10927#206188, @bu5hm4n wrote:

No no, item is the problem. And we use item in CV as well.
And the index in a item is int.

Oh dang, why! I didn't even know we had that there... CV is not using it nor filling it properly I would bet.

Mhm, I hope :)