Depends on D10677
Details
Diff Detail
- Repository
- rEFL core/efl
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Mhm, this needs more "things" i think.
- grid pm still returns -1
- list pm still returns -1
- collection still uses unsigned int
- collection_view still checks for id < 0.
In general, i don't understand why this has to be unsigned...
Need fixing. Will look at them.
In general, i don't understand why this has to be unsigned...
The unsigned int is the upper limit of the maximum amount of information you can carry in a model. For example your facebook or twitter history is limited to that much forever. The higher limit, we build in now, is I would think the better for the future.
rebase, address other component not using unsigned int and side effect fix the bug of over shooting upper limit of objects.
Mhm, but then we already have a problem, you can have at MAX INT_MAX items in a collection, as the index in item is a signed int.
Collection is not really a problem here as it will never be possible in term of performance to reach even close to INT_MAX (If we reach on a modern PC SHORT_MAX as a limit, I will be happy). In the case of CollectionView, this is still a possibly doable goal.
No no, item is the problem. And we use item in CV as well.
And the index in a item is int.
Oh dang, why! I didn't even know we had that there... CV is not using it nor filling it properly I would bet.
src/lib/elementary/efl_ui_position_manager_entity.eo | ||
---|---|---|
110 | ... F...O...R...M...A...T...T...I...N...G... |