Page MenuHomePhabricator

eolian: inherit since information from struct and enum to field
ClosedPublic

Authored by felipealmeida on Dec 22 2019, 5:34 AM.

Details

Summary

If a struct or enum field doesn't explicitly sets since information, then since
is inherited from struct documentation if it is available.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 15118
felipealmeida created this revision.Dec 22 2019, 5:34 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

felipealmeida requested review of this revision.Dec 22 2019, 5:34 AM
q66 accepted this revision.Dec 22 2019, 8:49 AM
This revision is now accepted and ready to land.Dec 22 2019, 8:49 AM
q66 added a comment.Dec 22 2019, 8:49 AM

We should do the same thing for enums.

This revision was automatically updated to reflect the committed changes.

@felipealmeida

This patch creates some errors in "ninja test". Please fix them.

woohyun reopened this revision.Dec 22 2019, 11:50 PM
This revision is now accepted and ready to land.Dec 22 2019, 11:50 PM
felipealmeida retitled this revision from eolian: inherit since information from struct to field to eolian: inherit since information from struct and enum to field.
felipealmeida edited the summary of this revision. (Show Details)

Fixed eolian tests for new docs. Add same feature to enums.

q66 added a comment.Dec 23 2019, 10:11 AM

I think the revision is wrong, it doesn't contain the previous changes but it should because they were reverted

I think it includes it. Is just that the code in parse_struct and in parse_enums is exactly the same.

q66 accepted this revision.Dec 23 2019, 10:24 AM

Hm, it displays now. Previously phab would not show it.

woohyun accepted this revision.Dec 23 2019, 2:35 PM

This seems ok now :) Thank you.

This revision was automatically updated to reflect the committed changes.