eolian: inherit since information from struct and enum to field
ClosedPublic
Actions

Authored by felipealmeida on Dec 22 2019, 5:34 AM.

Details

Reviewers

Maniphest Tasks

Commits

Summary

If a struct or enum field doesn't explicitly sets since information, then since
is inherited from struct documentation if it is available.

Repository

rEFL core/efl

Branch

master

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 15118

felipealmeida created this revision.Dec 22 2019, 5:34 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

felipealmeida requested review of this revision.Dec 22 2019, 5:34 AM

felipealmeida added a reviewer: q66.

q66 accepted this revision.Dec 22 2019, 8:49 AM

This revision is now accepted and ready to land.Dec 22 2019, 8:49 AM

We should do the same thing for enums.

This revision was automatically updated to reflect the committed changes.

This patch creates some errors in "ninja test". Please fix them.

This revision is now accepted and ready to land.Dec 22 2019, 11:50 PM

Fixed eolian tests for new docs. Add same feature to enums.

I think the revision is wrong, it doesn't contain the previous changes but it should because they were reverted

I think it includes it. Is just that the code in parse_struct and in parse_enums is exactly the same.

Hm, it displays now. Previously phab would not show it.

This seems ok now :) Thank you.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
~			src/lib/eolian/eo_parser.c (4 lines)
~			src/tests/eolian/data/docs_ref.h (18 lines)
~			src/tests/eolian/data/eo_docs.eo (4 lines)
~			src/tests/eolian/eolian_parsing.c (3 lines)
~			src/tests/eolian_cxx/eolian_cxx_test_documentation.cc (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	27740	c498800		Dec 22 2019, 5:34 AM	★	★
Diff 2	27745	4740747	rEFLf349510941a81649cbd040774c3d4939429e3293	Dec 22 2019, 5:21 PM	★	★
Diff 3	27769	b90c50a	Fixed eolian tests for new docs. Add same feature to enums.	Dec 23 2019, 8:33 AM	★	★
Diff 4	27785	5679a5d	rEFLb3cc7d403b4a9f69f2ad8c4bbd37e482f34e6deb	Dec 23 2019, 2:26 PM	★	★