Page MenuHomePhabricator

elm_entry: remove variation sequences as part of glyph when delete clusters
ClosedPublic

Authored by ali.alzyod on Mon, Dec 23, 6:58 AM.

Details

Summary

This will fix the task:
T8542

Remove variation sequences as part of glyph when deleting clusters, variation sequence is meaningless alone, so they should be removed when deleting

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ali.alzyod created this revision.Mon, Dec 23, 6:58 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Mon, Dec 23, 6:58 AM
ali.alzyod edited the summary of this revision. (Show Details)
ali.alzyod updated this revision to Diff 27777.Mon, Dec 23, 9:23 AM

depend on variation sequence at cursor position

ali.alzyod retitled this revision from elm_entry: remove 0 size glyph when delete clusters to elm_entry: remove variation sequences as part of glyph when delete clusters.Mon, Dec 23, 9:26 AM
ali.alzyod edited the summary of this revision. (Show Details)
bowonryu accepted this revision.Tue, Dec 24, 12:21 AM

This problem is related to whether the font contains a glyph representation.
However, this patch guarantees clustered remove of 'Char' + 'U+FE0E' regardless of the font glyph.
So I think this patch is necessary.

This revision is now accepted and ready to land.Tue, Dec 24, 12:21 AM
woohyun added inline comments.Tue, Dec 24, 12:29 AM
src/lib/evas/canvas/evas_object_textblock.c
10159

I think "int i = 0" looks better to be in the original location.

ali.alzyod marked an inline comment as done.Tue, Dec 24, 12:32 AM
This revision was automatically updated to reflect the committed changes.