Page MenuHomePhabricator

correct edje pkg-config generation for luaold
ClosedPublic

Authored by rvandegrift on Dec 24 2019, 8:33 PM.

Details

Summary

Currently, edje.pc gets its lua Requires from the -Dlua-interpreter argument.
If -Dlua-interpreter=lua, an unversioned lua entry ends up in Requires, which
cannot always be satisifed. The evas filters meson.build handles this case by
generating a version-specific entry. This patch copies that logic into the top
level meson.build, and passes the result to the edje subproject.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rvandegrift created this revision.Dec 24 2019, 8:33 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

rvandegrift requested review of this revision.Dec 24 2019, 8:33 PM

Tests running on : https://travis-ci.org/Enlightenment/efl/builds/629963396 i additionally removed duplicated codes around.

bu5hm4n accepted this revision.Dec 28 2019, 1:34 AM

Okay, after a bit of wrestling with macos we are finally down to a solution. Thank you very much for tracking this down :)

The patch that is landing has a few fixes for macos, and a few dedpulcation things in it.

Again, Thank you a lot :)

This revision is now accepted and ready to land.Dec 28 2019, 1:34 AM
Closed by commit rEFL2e854ce7ed5a: correct edje pkg-config generation for luaold (authored by rvandegrift, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyDec 28 2019, 1:48 AM
This revision was automatically updated to reflect the committed changes.