Page MenuHomePhabricator

efl.text.interactive: remove event freeze when keyboard button is pressed
ClosedPublic

Authored by ali.alzyod on Dec 29 2019, 1:49 AM.

Details

Summary

this event freeze will prevent submission of EFL_UI_TEXTBOX_EVENT_CHANGED on efl.ui.textbox object, when inserting text using the keyboard.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ali.alzyod created this revision.Dec 29 2019, 1:49 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Dec 29 2019, 1:49 AM
ali.alzyod edited the summary of this revision. (Show Details)Dec 29 2019, 3:20 AM
ali.alzyod added reviewers: woohyun, zmike, bu5hm4n.

@ali.alzyod

4dc2001dac617a8cd9a7381b4de83bcc68578859

Ui text: reduce calls to update functions  

Reduces calls to update functions when entering text.
Also, remaining calls to update the cursors were moved to the decoration
jobs.

Previously, the event_freeze seemed to be in charge of reducing calls.
So, before removing that, I hope to check what was the meaning of "reducing calls".

If there is nothing to be changed after removing that event_freeze, then I will accept the patch :)

@ali.alzyod

4dc2001dac617a8cd9a7381b4de83bcc68578859

Ui text: reduce calls to update functions  

Reduces calls to update functions when entering text.
Also, remaining calls to update the cursors were moved to the decoration
jobs.

Previously, the event_freeze seemed to be in charge of reducing calls.
So, before removing that, I hope to check what was the meaning of "reducing calls".

If there is nothing to be changed after removing that event_freeze, then I will accept the patch :)

Thank you for notice
I feel this is a workaround to enhance performance, but It is only working with adding text by keyboard, (doesnot do same logic with removing text with the keyboard or from clipboard)
Also, this will break event submission for objects listen to efl.ui.internal.text.interactive EFL_CANVAS_TEXT_EVENT_CHANGED

If there are any improvements, it should be done in EFL.UI.TEXTBOX which listens to these events.

bu5hm4n accepted this revision.Jan 2 2020, 3:02 AM

@woohyun i am landing this for now - as this caused bugs.

This revision is now accepted and ready to land.Jan 2 2020, 3:02 AM
Closed by commit rEFLa95a509cfd9d: efl.text.interactive: remove event freeze when keyboard button is pressed (authored by ali.alzyod, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyJan 2 2020, 3:04 AM
This revision was automatically updated to reflect the committed changes.