simplify code, and reduce calls:
It is only required to set scroll mode in two cases:
- When creating scroller
- When changing multiline property
woohyun | |
zmike | |
bu5hm4n |
simplify code, and reduce calls:
It is only required to set scroll mode in two cases:
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/
src/lib/elementary/efl_ui_textbox.c | ||
---|---|---|
2127 | I cannot find out where this function is called ..... Am I missing something ? |
src/lib/elementary/efl_ui_textbox.c | ||
---|---|---|
2127 | this is overriding for Efl.Text_Format.multiline {set;} in efl.textbox |
src/lib/elementary/efl_ui_textbox.c | ||
---|---|---|
2130 | I do not understand this early return. How can I disable multiline then? |
This is indeed a good catch.
Can you also remove smanager from Efl_Ui_Internal_Text_Scroller_Data ? As this is not used anymore now.
src/lib/elementary/efl_ui_internal_text_scroller.c | ||
---|---|---|
140 | Mhm, i am not a fan of this. The flow of value of mulitline seems to come from textbox, the internal scroller should not eval this value. | |
src/lib/elementary/efl_ui_textbox.c | ||
2126 | Can you add EOLIAN here ? | |
2130 | @segfaultxavi this just returns when the values are the same, so you can disable mulitple by passing enabled=false, which will just work :) | |
src/lib/elementary/efl_ui_textbox.eo | ||
109 | Can you also remove this here? |
Additionally, i think efl_ui_internal_text_scroller_mode_set must be set when sd->scroller is created.
src/lib/elementary/efl_ui_textbox.c | ||
---|---|---|
2130 | Apologies, I brainfarted. |