Page MenuHomePhabricator

ecore_evas_buffer: Unregister input events when ecore_evas_buffer is freed
ClosedPublic

Authored by eagleeye on Dec 29 2019, 7:41 PM.

Details

Summary

When ecore_evas_buffer is freed, input events is not unregistered.
So _window_hash size is increasing.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
eagleeye created this revision.Dec 29 2019, 7:41 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

eagleeye requested review of this revision.Dec 29 2019, 7:41 PM
eagleeye edited the summary of this revision. (Show Details)Dec 29 2019, 7:43 PM
eagleeye added reviewers: Hermet, cedric, raster.
zmike accepted this revision.Dec 30 2019, 8:16 AM
zmike added a subscriber: zmike.

Hm this seems reasonable. We don't explicitly register these during setup, but there's no harm in unregistering them during free for safety.

This revision is now accepted and ready to land.Dec 30 2019, 8:16 AM
Closed by commit rEFL9c41899a085f: ecore_evas_buffer: Unregister input events when ecore_evas_buffer is freed (authored by Hosang Kim <hosang12.kim@samsung.com>, committed by zmike). · Explain WhyDec 30 2019, 8:26 AM
This revision was automatically updated to reflect the committed changes.

Hm this seems reasonable. We don't explicitly register these during setup, but there's no harm in unregistering them during free for safety.

We register it at ecore_evas_done() :)

zmike added a comment.Dec 30 2019, 8:41 AM

Aha! Thanks, I missed that. I wonder if we should add checks into ecore_event_window_register() to prevent double-adds?