Page MenuHomePhabricator

evas: fix legacy evas_object_clip_unset for group object.
ClosedPublic

Authored by SanghyeonLee on Dec 30 2019, 4:40 AM.

Details

Summary

evas_object_clip_unset was broken for group object in several month or year..

basically,
evas_object_clip_unset(obj)
efl_canvas_object_clipper_set(obj, NULL)
is equal on efl_clip implements,
but on the group object, we need to unclip the whole group children in
efl_canvas_group_efl_canvas_object_clipper_set
which was not performed by legacy clip_usnet API.

Test Plan

try clip_unset(obj) and clipper_set(obj, NULL) in any group clipped case
(i.e. scroller content) and see clip_unset is broken and fixed by patch.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15179
Build 10465: arc lint + arc unit
SanghyeonLee created this revision.Dec 30 2019, 4:40 AM
SanghyeonLee requested review of this revision.Dec 30 2019, 4:41 AM
zmike added a comment.Dec 30 2019, 8:18 AM

In this case can't we remove those safety checks as well? Good find!

remove smart check.

zmike accepted this revision.Dec 31 2019, 6:48 AM
This revision is now accepted and ready to land.Dec 31 2019, 6:48 AM
This revision was automatically updated to reflect the committed changes.