Page MenuHomePhabricator

elementary_text: Efl.Ui.Textbox Input Field
ClosedPublic

Authored by ali.alzyod on Dec 30 2019, 6:15 AM.

Details

Summary

Entry was added to the same box. This commit fixes this.
You could observe this problem when starting the "Textbox Input Field" demo in elm_test

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ali.alzyod created this revision.Dec 30 2019, 6:15 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Dec 30 2019, 6:15 AM
ali.alzyod added inline comments.Dec 30 2019, 6:16 AM
src/bin/elementary/test_efl_ui_text.c
229

This call already add the widget to the box

segfaultxavi requested changes to this revision.Dec 30 2019, 7:48 AM
segfaultxavi added a subscriber: segfaultxavi.

Please explain in the commit message what this patch is doing.
Also, add some reviewers.

This revision now requires changes to proceed.Dec 30 2019, 7:48 AM
ali.alzyod edited the summary of this revision. (Show Details)Dec 30 2019, 7:53 AM

Please explain in the commit message what this patch is doing.
Also, add some reviewers.

Fix a bug, that simple :)

ali.alzyod requested review of this revision.Dec 30 2019, 7:56 AM
ali.alzyod added inline comments.Dec 30 2019, 8:02 AM
src/bin/elementary/test_efl_ui_text.c
229

_create_label internally add the return en to the passed box

ali.alzyod edited the summary of this revision. (Show Details)Dec 30 2019, 8:21 AM
bu5hm4n accepted this revision.Dec 31 2019, 2:29 AM
bu5hm4n retitled this revision from elemenry_text: Efl.Ui.Textbox Input Field to elementary_text: Efl.Ui.Textbox Input Field.
bu5hm4n edited the summary of this revision. (Show Details)

@segfaultxavi i updated the commit message, I hope this is clear now :)

This revision was not accepted when it landed; it landed in state Needs Review.Dec 31 2019, 2:42 AM
Closed by commit rEFL2ec10f18d33c: elementary_text: Efl.Ui.Textbox Input Field (authored by ali.alzyod, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain Why
This revision was automatically updated to reflect the committed changes.