Page MenuHomePhabricator
Differential D10987

efl_ui_text: support focus navigation
ClosedPublic
Actions

Authored by ali.alzyod on Dec 30 2019, 7:36 AM.

Details

Reviewers
woohyun
zmike
bu5hm4n
Maniphest Tasks
T8538: efl.ui.text key navigation issues
T8522: Efl.Ui.Textbox class
Commits
rEFL5154b5a8fca0: efl_ui_text: support focus navigation
Summary

With this commit you can move the focus from the textbox widget to the surrounding widgets, (as it is done in legacy).

ref T8538
ref T8522

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ali.alzyod created this revision.Dec 30 2019, 7:36 AM
Herald added a project: efl. · View Herald TranscriptDec 30 2019, 7:36 AM
Herald added subscribers: committers, reviewers, cedric. · View Herald Transcript

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Dec 30 2019, 7:36 AM
ali.alzyod edited the summary of this revision. (Show Details)Dec 30 2019, 11:48 PM
ali.alzyod added reviewers: woohyun, zmike, bu5hm4n.
bu5hm4n retitled this revision from efl_ui_text: lose focuse using arrow keys to efl_ui_text: support focus navigation.Dec 31 2019, 2:35 AM
bu5hm4n edited the summary of this revision. (Show Details)
bu5hm4n edited the summary of this revision. (Show Details)
bu5hm4n added a task: T8538: efl.ui.text key navigation issues.
bu5hm4n accepted this revision.Dec 31 2019, 2:37 AM

Thank you :)

Can you next time write more concrete commit messages ? Additionally, always add "ref TXXXX" or "fixes TXXXX" to the commit messages, so we have a clear log of how things are fixed :)

This revision is now accepted and ready to land.Dec 31 2019, 2:37 AM
bu5hm4n added a comment.Dec 31 2019, 2:56 AM

I am going to land it in this state, however: Can you next time only commit changes that are relevant to this ? :)

Closed by commit rEFL5154b5a8fca0: efl_ui_text: support focus navigation (authored by ali.alzyod, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyDec 31 2019, 3:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27886

View Options

src/lib/elementary/efl_ui_internal_text_interactive.c

Loading...
View Options

src/lib/elementary/efl_ui_textbox.c

Loading...