Page MenuHomePhabricator

evas vg: add an new interface efl_canvas_vg_container_children_direct_get()
ClosedPublic

Authored by Hermet on Dec 30 2019, 9:18 PM.

Details

Summary

We need an efficient method to navigate children faster.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Hermet created this revision.Dec 30 2019, 9:18 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

Hermet requested review of this revision.Dec 30 2019, 9:19 PM
jsuya accepted this revision.Dec 30 2019, 9:37 PM
This revision is now accepted and ready to land.Dec 30 2019, 9:37 PM
jsuya added a comment.Dec 30 2019, 9:42 PM

I think it's better to replace iterator with eina_list. But I don't think this is bad either.

This revision was automatically updated to reflect the committed changes.

Why is there a direct list needed, we tried to stay away from a list in any public API, and replaced everything with iterators, as the lifetime of a list is quite questionably.

I agree with @bu5hm4n and I think we have some goal of removing list and hash from eolian rather sooner than later.