Page MenuHomePhabricator

efl.ui.textbox: replace legacy scroller type check
ClosedPublic

Authored by ali.alzyod on Jan 2 2020, 2:00 AM.

Details

Summary

replace legacy scroller type check ELM_INTERFACE_SCROLLABLE_MIXIN with EFL_UI_SCROLLABLE_INTERFACE

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ali.alzyod created this revision.Jan 2 2020, 2:00 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Jan 2 2020, 2:00 AM
ali.alzyod edited the summary of this revision. (Show Details)Jan 2 2020, 2:01 AM
ali.alzyod added reviewers: woohyun, bu5hm4n.
bu5hm4n accepted this revision.Jan 6 2020, 4:48 AM
bu5hm4n added inline comments.
src/lib/elementary/efl_ui_textbox.c
441

For another revision, you can replace these 3 lines with Eina_Rect r = efl_gfx_entity_geometry_get(parent)

This revision is now accepted and ready to land.Jan 6 2020, 4:48 AM
Closed by commit rEFL31a96be9a28f: efl.ui.textbox: replace legacy scroller type check (authored by ali.alzyod, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyJan 6 2020, 5:38 AM
This revision was automatically updated to reflect the committed changes.