Page MenuHomePhabricator

efl_ui_timepicker: make 24h mode work
ClosedPublic

Authored by bu5hm4n on Jan 2 2020, 2:45 AM.

Details

Summary

this is something which was never ever working before. However, while
fixing the 24h mode, it also appeared that the theming was applied in
the wrong spot, which resulted in signals beeing called on a not yet
themed object, so the theming was also fixed. (Which is the theme_apply
change).

To sum up:

  • The theme is now applied by efl_ui_layout_base
  • the range is now correct for 24h mode
  • There is a quite major problem with the theme, see T8546
  • As a quick fix, am / pm button can be disabled.

ref T8546

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Jan 2 2020, 2:45 AM
bu5hm4n requested review of this revision.Jan 2 2020, 2:45 AM
zmike added a subscriber: woohyun.

@woohyun who is working on timepicker? This am/pm issue should probably be looked at in some detail

This revision was not accepted when it landed; it landed in state Needs Review.Jan 13 2020, 6:57 AM
Closed by commit rEFLbbdab35a7a91: efl_ui_timepicker: make 24h mode work (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain Why
This revision was automatically updated to reflect the committed changes.