Page MenuHomePhabricator

Evas Textblock : Fix obstacles & word overlap
ClosedPublic

Authored by AbdullehGhujeh on Jan 2 2020, 6:16 AM.

Details

Summary

Revert part of old commit which caused wrong behavior in textblock with obstacles, we should use obstacle x pos.
There is no comments about why this was changed.

Old commit is :
Aug 23, 2017 e63be982d904a01ade5aced9ef9924a78d155b8a

related to D10955

Test Plan

Run Textblock Obstacle example

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
AbdullehGhujeh created this revision.Jan 2 2020, 6:16 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

AbdullehGhujeh requested review of this revision.Jan 2 2020, 6:16 AM
AbdullehGhujeh edited the summary of this revision. (Show Details)Jan 2 2020, 6:23 AM
AbdullehGhujeh edited the test plan for this revision. (Show Details)
AbdullehGhujeh added reviewers: ali.alzyod, woohyun.
AbdullehGhujeh edited the summary of this revision. (Show Details)Jan 2 2020, 6:26 AM
AbdullehGhujeh added a reviewer: segfaultxavi.
woohyun accepted this revision.Jan 2 2020, 11:50 PM

I think this looks correct fix. Thanks.

This revision is now accepted and ready to land.Jan 2 2020, 11:50 PM
Closed by commit rEFLc9cc3ab3f0d0: Evas Textblock : Fix obstacles & word overlap (authored by abdulleh Ghujeh <a.ghujeh@samsung.com>, committed by woohyun). · Explain WhyJan 2 2020, 11:50 PM
This revision was automatically updated to reflect the committed changes.