Page MenuHomePhabricator
Differential D11010

efl_ui_spin_button: add tests for direct input feature
Needs ReviewPublic
Actions

Authored by bu5hm4n on Fri, Jan 3, 10:39 AM.

Details

Reviewers
zmike
segfaultxavi
cedric
Commits
rEFLf62cee28cbb6: efl_ui_spin_button: add tests for direct input feature
Summary

this simply passes in some key sequences and checks if the validation is
working. Additionally the output value is checked.
Depends on D11009

Depends on D11079

Diff Detail

Repository
rEFL core/efl
Branch
devs/bu5hm4n/work_asdf
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 15350
bu5hm4n created this revision.Fri, Jan 3, 10:39 AM
Herald added a project: efl. · View Herald TranscriptFri, Jan 3, 10:39 AM
Herald added subscribers: committers, reviewers, cedric. · View Herald Transcript

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Jan 13, 6:58 AM
Closed by commit rEFLf62cee28cbb6: efl_ui_spin_button: add tests for direct input feature (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain Why
This revision was automatically updated to reflect the committed changes.
bu5hm4n reopened this revision.Mon, Jan 13, 11:18 AM
bu5hm4n updated this revision to Diff 28124.Mon, Jan 13, 11:19 AM
bu5hm4n edited the summary of this revision. (Show Details)
bu5hm4n added a parent revision: D11079: efl_ui_selection: return ERRORS when setting the selection failed.

more work on this

bu5hm4n added a subscriber: segfaultxavi.Mon, Jan 13, 11:20 AM

This is still failing on travis in a Segfault that i cannot reproduce here locally.

@segfaultxavi is this also failing for you ?

segfaultxavi added a comment.Mon, Jan 13, 11:34 AM

Still failing for me, same place :(

../src/tests/elementary/efl_ui_test_spin_button.c:222:E:efl_ui_spin_button:spin_direct_text_input:0: (after this point) Received signal 11 (Segmentation fault)
../src/tests/elementary/efl_ui_test_spin_button.c:222:E:efl_ui_spin_button:spin_direct_text_input_comma_value:0: (after this point) Received signal 11 (Segmentation fault)
bu5hm4n added a comment.Mon, Jan 13, 11:41 AM

Can you now get a backtrace ? One thing is the crash with all details, but at a minimum thing the symbol names would be very good.

Revision Contents
Changeset List

Diff 28124

View Options

src/tests/elementary/efl_ui_test_spin_button.c

Loading...
View Options

src/tests/elementary/suite_helpers.h

Loading...
View Options

src/tests/elementary/suite_helpers.c

Loading...