Page MenuHomePhabricator

Efl.Ui.Vg_Animation: Fix state when changed speed
ClosedPublic

Authored by jsuya on Jan 5 2020, 10:22 PM.

Details

Summary

If speed's direction changed, change state.

Test Plan

N/A

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jsuya created this revision.Jan 5 2020, 10:22 PM
jsuya requested review of this revision.Jan 5 2020, 10:22 PM
Hermet requested changes to this revision.Jan 6 2020, 5:24 PM

Please check my comment.

src/lib/elementary/efl_ui_vg_animation.c
788–789

This condition is too naughty.
I think this should be refactored to maintain.

if condition 1 (play & speed):

play -> play_back

else condition 2 (play_back & speed):

play_back -> play
This revision now requires changes to proceed.Jan 6 2020, 5:24 PM
jsuya updated this revision to Diff 27981.Jan 6 2020, 5:41 PM

update code

jsuya marked an inline comment as done.Jan 6 2020, 5:41 PM
jsuya added inline comments.
src/lib/elementary/efl_ui_vg_animation.c
788–789

i update code. please check again

Hermet accepted this revision.Jan 6 2020, 10:51 PM
This revision is now accepted and ready to land.Jan 6 2020, 10:51 PM
This revision was automatically updated to reflect the committed changes.