Page MenuHomePhabricator

tests: Add test cases for Efl.Ui.Vg_Animation
ClosedPublic

Authored by jsuya on Sun, Jan 5, 10:28 PM.

Details

Summary

Add test cases for Efl.Ui.Vg_Animation APIs

  • vg_anim_playing_control
  • vg_anim_frame_control

ref T8476
Depends on D11021

Test Plan

cd builddir/src/tests/elementary
./efl_ui_suite efl_ui_vg_animation

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jsuya created this revision.Sun, Jan 5, 10:28 PM
jsuya requested review of this revision.Sun, Jan 5, 10:28 PM

Thanks a lot for these tests, i will review them more in depth later on. Something else before, is the case handled that there is no lottie support build ?

bu5hm4n requested changes to this revision.Mon, Jan 6, 4:09 AM

Looks good beside that.

src/tests/elementary/efl_ui_test_vg_animation.c
90

int eq with a double value ? That cannot be what you want.

please use ck_assert(EINA_DBL_EQ(..., 0.3));

Same for the other double cases around here.

118

Can you add:

tcase_add_checked_fixture(tc, fail_on_errors_setup, fail_on_errors_teardown);

here ? That will ensure that the tests fail when there are errors printed.

This revision now requires changes to proceed.Mon, Jan 6, 4:09 AM

Ah - and handle the case of lottie not enabled.

jsuya updated this revision to Diff 28072.Thu, Jan 9, 11:26 PM

Update code

  • change ck function for double value.
  • add handle case of json loader not enabled.

thank you for review

jsuya marked 2 inline comments as done.Thu, Jan 9, 11:29 PM
bu5hm4n requested changes to this revision.Tue, Jan 14, 10:31 PM

But the rest looks good.

src/tests/elementary/efl_ui_test_vg_animation.c
41

This still compare double values with the int macro ...

44

This still compare double values with the int macro ...

This revision now requires changes to proceed.Tue, Jan 14, 10:31 PM
jsuya updated this revision to Diff 28204.Wed, Jan 15, 6:12 PM

Fix my mistake

jsuya marked 2 inline comments as done.Wed, Jan 15, 6:13 PM

thank you

bu5hm4n accepted this revision.Thu, Jan 16, 12:42 AM

Cool, thank you.

This revision is now accepted and ready to land.Thu, Jan 16, 12:42 AM
Closed by commit rEFL3a4c5cf6a5f3: tests: Add test cases for Efl.Ui.Vg_Animation (authored by jsuya, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyThu, Jan 16, 12:51 AM
This revision was automatically updated to reflect the committed changes.