Page MenuHomePhabricator

efl_ui_textbox: replace elm_obj stuff and focuse stuff
ClosedPublic

Authored by ali.alzyod on Jan 6 2020, 8:02 AM.

Details

Summary

efl_ui_textbox: replace elm_obj stuff and focuse stuff

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ali.alzyod created this revision.Jan 6 2020, 8:02 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Jan 6 2020, 8:02 AM
ali.alzyod edited the summary of this revision. (Show Details)Jan 6 2020, 8:02 AM
ali.alzyod added reviewers: woohyun, bu5hm4n.

@bu5hm4n
Could you check if the focus relating codes have any problem ?
The rest of the codes look good for me.

I am wondering if its just better to keep the focus where it is when dnd leaves, something else will grab the focus anyways when something is dropped somewhere else, pop_history_stack has the annoying sideeffect that it might be quite random when there was no element focused before :)

I am wondering if its just better to keep the focus where it is when dnd leaves, something else will grab the focus anyways when something is dropped somewhere else, pop_history_stack has the annoying sideeffect that it might be quite random when there was no element focused before :)

Do you suggest removing this condition? (at this point this is just replace for what legacy api was doing)

if (_elm_config->desktop_entry)
     {
        if (efl_ui_focus_manager_focus_get(efl_ui_focus_object_focus_manager_get(obj)) == obj)
               efl_ui_focus_manager_pop_history_stack(efl_ui_focus_object_focus_manager_get(obj));
     }

I would remove it.

If dnd hits some other widget that can handle a "drop", then this widget should request focus. Otherwise, leave the focus where it is ... on the entry for now ... :)

ali.alzyod updated this revision to Diff 28008.Jan 8 2020, 3:54 AM

remove dnd_leave procedures

bu5hm4n accepted this revision.Jan 8 2020, 3:56 AM

Looks good to me, @woohyun any last complains ? :)

This revision is now accepted and ready to land.Jan 8 2020, 3:56 AM
woohyun accepted this revision.Jan 8 2020, 8:48 PM

@bu5hm4n

Nothing :) Looks good for me.
Accepted !

This revision was automatically updated to reflect the committed changes.