It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

@bu5hm4n
Could you check if the focus relating codes have any problem ?
The rest of the codes look good for me.

I am wondering if its just better to keep the focus where it is when dnd leaves, something else will grab the focus anyways when something is dropped somewhere else, pop_history_stack has the annoying sideeffect that it might be quite random when there was no element focused before :)

In D11025#208298, @bu5hm4n wrote:

I am wondering if its just better to keep the focus where it is when dnd leaves, something else will grab the focus anyways when something is dropped somewhere else, pop_history_stack has the annoying sideeffect that it might be quite random when there was no element focused before :)

Do you suggest removing this condition? (at this point this is just replace for what legacy api was doing)

if (_elm_config->desktop_entry)
     {
        if (efl_ui_focus_manager_focus_get(efl_ui_focus_object_focus_manager_get(obj)) == obj)
               efl_ui_focus_manager_pop_history_stack(efl_ui_focus_object_focus_manager_get(obj));
     }

I would remove it.

If dnd hits some other widget that can handle a "drop", then this widget should request focus. Otherwise, leave the focus where it is ... on the entry for now ... :)