Page MenuHomePhabricator

elementary: do not use list<> in Efl.Ui.Focus_Manager.
AcceptedPublic

Authored by cedric on Wed, Jan 8, 10:41 AM.

Details

Summary

Depends on D11050

Diff Detail

Repository
rEFL core/efl
Branch
devs/cedric/list-removal
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 15409
cedric created this revision.Wed, Jan 8, 10:41 AM
cedric requested review of this revision.Wed, Jan 8, 10:41 AM
q66 resigned from this revision.Thu, Jan 9, 6:37 AM

this looks fine to me but better reviewed by @bu5hm4n

Mhm the only user of that was clouseau ... But that one does not even compile after renames and eolian changes, what should we do ?

Mhm the only user of that was clouseau ... But that one does not even compile after renames and eolian changes, what should we do ?

Maybe work with the assumption that maybe someone at some point might maybe make clouseau work again and so still provide the API for it to be revived. It doesn't seems to be much change to adapt software that would be using this code.

yeah, probably true.

bu5hm4n accepted this revision.Thu, Jan 16, 12:29 AM
This revision is now accepted and ready to land.Thu, Jan 16, 12:29 AM
bu5hm4n added inline comments.Thu, Jan 16, 12:30 AM
src/lib/elementary/efl_ui_focus_manager_calc.c
1861

One last question, (I cannot take back the accepted right now): would you use the processed_iterator if we land that before ?

cedric added inline comments.Thu, Jan 16, 8:06 AM
src/lib/elementary/efl_ui_focus_manager_calc.c
1861

Most likely yes.