Page MenuHomePhabricator

efl.input.text: add variation enums + remove @since word
ClosedPublic

Authored by ali.alzyod on Jan 12 2020, 12:37 AM.

Details

Summary

efl.input.text: add variation enums + remove @since word

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ali.alzyod created this revision.Jan 12 2020, 12:37 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Jan 12 2020, 12:37 AM
ali.alzyod added reviewers: woohyun, segfaultxavi.
ali.alzyod edited the summary of this revision. (Show Details)
segfaultxavi requested changes to this revision.Jan 12 2020, 3:14 AM
segfaultxavi added inline comments.
src/lib/efl/interfaces/efl_input_text.eo
69–70

This @since should be removed too.

92

This means that each word is automatically capitalized, right? This should be explained in the docs.

100

The docs for signed and decimal are repeated.

This revision now requires changes to proceed.Jan 12 2020, 3:14 AM
ali.alzyod updated this revision to Diff 28092.Jan 12 2020, 4:50 AM
ali.alzyod marked 3 inline comments as done.

update

segfaultxavi accepted this revision.Jan 13 2020, 7:33 AM

Looks good to me.
Builds and passes tests.

This revision is now accepted and ready to land.Jan 13 2020, 7:33 AM
This revision was automatically updated to reflect the committed changes.