Page MenuHomePhabricator

efl.ui.textbox: legacy cleanup
ClosedPublic

Authored by ali.alzyod on Jan 12 2020, 8:30 AM.

Details

Summary

efl.ui.textbox: legacy cleanup

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ali.alzyod created this revision.Jan 12 2020, 8:30 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Jan 12 2020, 8:30 AM
ali.alzyod updated this revision to Diff 28094.

update

ali.alzyod edited the summary of this revision. (Show Details)Jan 12 2020, 8:31 AM
ali.alzyod added reviewers: woohyun, bu5hm4n.
bu5hm4n accepted this revision.Jan 13 2020, 3:26 AM
This revision is now accepted and ready to land.Jan 13 2020, 3:26 AM
Closed by commit rEFL2201b562d019: efl.ui.textbox: legacy cleanup (authored by ali.alzyod, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyJan 13 2020, 3:26 AM
This revision was automatically updated to reflect the committed changes.

For the future, "legacy cleanup" sounds like you are cleaning legacy stuff (like removing methods, for example). A more fitting title would be "Use Unified API instead of Legacy".
It's just a minor detail, but it helps when browsing lots of commits and you only have time to read the summary :)