Page MenuHomePhabricator

efl.ui.textbox: paste in mouse button 2
ClosedPublic

Authored by ali.alzyod on Sun, Jan 12, 8:53 AM.

Details

Summary

efl.ui.textbox: paste in mouse button 2 work on primary instead of clipboard

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ali.alzyod created this revision.Sun, Jan 12, 8:53 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Sun, Jan 12, 8:53 AM
ali.alzyod retitled this revision from efl.ui.textbox: legacy cleanup to efl.ui.textbox: paste in mouse button 2.Sun, Jan 12, 8:55 AM
ali.alzyod edited the summary of this revision. (Show Details)
bu5hm4n requested changes to this revision.Mon, Jan 13, 3:35 AM
bu5hm4n added a subscriber: bu5hm4n.

Does not apply

This revision now requires changes to proceed.Mon, Jan 13, 3:35 AM
bu5hm4n accepted this revision.Wed, Jan 15, 2:03 AM

Does what it should do

src/lib/elementary/efl_ui_textbox.c
2190–2191

Next time, make such a function static, and a newline after the void

This revision is now accepted and ready to land.Wed, Jan 15, 2:03 AM
Closed by commit rEFL4386a70177f1: efl.ui.textbox: paste in mouse button 2 (authored by ali.alzyod, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyWed, Jan 15, 2:04 AM
This revision was automatically updated to reflect the committed changes.
ali.alzyod added inline comments.Wed, Jan 15, 3:20 AM
src/lib/elementary/efl_ui_textbox.c
2190–2191

Dear @bu5hm4n , language, and tone is very important to avoid misunderstanding.
I do not feel it is nice to tell people next time, make this, if you use better words like this should be.
This makes a lot of difference when talking with people. (try to focus on the subject not the people)

bu5hm4n added inline comments.Wed, Jan 15, 4:08 AM
src/lib/elementary/efl_ui_textbox.c
2190–2191

This is not meant negative, i only wrote "next time" because i just fixed it myself instead of another round of fixing.
I am not writing comments based on who the author is, i would have written exactly the same for any other person.

ProhtMeyhet added inline comments.
src/lib/elementary/efl_ui_textbox.c
2190–2191

Simply add a please. So Next time, please make and it will sound much nicer :-)

ali.alzyod added inline comments.Wed, Jan 15, 4:31 AM
src/lib/elementary/efl_ui_textbox.c
2190–2191

I am not writing comments based on who the author is, i would have written exactly the same for any other person.

I know you did not write this because it is me :)
I mean next time, make this, this is request for person, this should be this request about the subject, they are the same, but second one can not be misunderstand.

@ProhtMeyhet :)) nice one. (The magic word)

a.srour reopened this revision.Wed, Jan 15, 5:21 AM
This revision is now accepted and ready to land.Wed, Jan 15, 5:21 AM
a.srour closed this revision.Wed, Jan 15, 5:22 AM