efl.ui.textbox: replace hoversel with popup
I think this may need some changes, please let me know what you think
It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/
That's a good start, a few things should be fixed however.
This will not work with translation, text will not be Copy for example.
can you rename to hoversel to popup ?
Mhm, what do you think of listening to the selection changed events of the items in the list, that would safe you the code above that needs to do string compares.
I am not sure if the backwall should emit clicked when rightclicked, it normally is just meant to react on left click.
This looks like a good start, a few more things then we are good to go i guess. With the changes now mentioned this should also cleanup a fair amount of code.
@zmike is it possible that this positioning code is basically available via popup internals ?
Do you know if this job is really needed, i am not sure why we have it, the popup will be deleted in _backwall_clicked anyways.
Can you refactor
EFL_UI_TEXT_DATA_GET(data, sd); efl_del(sd->popup_list); efl_del(sd->popup); sd->popup_list = NULL; sd->popup = NULL;
Into a static inline void function ehre and call it in every _cb where they are the same, that would make the code a little bit smaller :)
this cause error in log when called on EFL_UI_EVENT_SELECTED_CHANGED
ERR<1606>:eina_safety ../src/lib/elementary/efl_ui_layout.c:1166 _efl_ui_layout_base_efl_layout_signal_signal_emit() safety check failed: efl_invalidated_get(obj) is true ERR<1606>:eina_safety ../src/lib/evas/canvas/evas_focus.c:226 _efl_canvas_object_seat_focus_add() safety check failed: !efl_invalidating_get(eo_obj) && !efl_invalidated_get(eo_obj) is false