Page MenuHomePhabricator

efl/player: merge in and rework events from vg_animation

Authored by zmike on Jan 13 2020, 9:53 AM.



this adds comprehensive events for the player interface which can be used
to provide details about the state of the playback

ref T8476

Depends on D11098

Diff Detail

rEFL core/efl
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Jan 13 2020, 9:53 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added:

zmike requested review of this revision.Jan 13 2020, 9:53 AM

Docs and new events look OK to me.

jsuya requested changes to this revision.Jan 13 2020, 4:53 PM
jsuya added a subscriber: jsuya.

Could you check the events in test_ui_efl_vg_animation.c and test_efl_gfx_vg_value_provider.c?
elm_animation_view_add is not declared as a legacy class that implements the Efl.Ui.Legacy interface.
As a result, the merge of this patch can cause problems with elm_animation_view behavior.

This revision now requires changes to proceed.Jan 13 2020, 4:53 PM
zmike updated this revision to Diff 28164.Jan 14 2020, 7:52 AM
zmike edited the summary of this revision. (Show Details)
zmike added a reviewer: bu5hm4n.


jsuya accepted this revision.Jan 14 2020, 8:50 PM

Thank you for your work.

This revision is now accepted and ready to land.Jan 14 2020, 8:50 PM
This revision was automatically updated to reflect the committed changes.