Differential D11088

efl/gesture: fix zoom to ignore single press events and not crash
AcceptedPublic
Actions

Authored by zmike on Mon, Jan 13, 12:13 PM.

Details

Reviewers

CHAN

Summary

zoom requires two fingers for a pinch, so skip the first press

Depends on D11087

Diff Detail

Repository

rEFL core/efl

Branch

master

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 15460

zmike created this revision.Mon, Jan 13, 12:13 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Mon, Jan 13, 12:13 PM

zmike added a child revision: D11089: tests/elm: add util functions for doing multi-touch events.

Harbormaster completed remote builds in B15366: Diff 28141.Mon, Jan 13, 12:18 PM

looks good to me

This revision is now accepted and ready to land.Thu, Jan 16, 9:52 PM

update

Harbormaster completed remote builds in B15460: Diff 28267.Fri, Jan 17, 7:46 AM

Revision Contents
Changeset List

			Path	Packages
~			src/lib/evas/gesture/efl_canvas_gesture_recognizer_zoom.c (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	28141	584f272		Mon, Jan 13, 12:13 PM	★	★
Diff 2	28267	e69dce8	update	Fri, Jan 17, 7:42 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
6305704198b2	74d46d4ae304	e69dce8f3c6f	Mike Blumenkrantz	(Show More…)	Mon, Jan 13, 12:09 PM

Status	Author	Revision
Closed	felipealmeida	D11099 C++: Fix use of @c_type tag in struct definition
Needs Review	zmike	D11126 efl/gesture: add touch_count property for gesture event info
Needs Review	zmike	D11090 tests/gesture: add gesture tests for basic multi-touch tap events
Needs Review	zmike	D11089 tests/elm: add util functions for doing multi-touch events
Accepted	zmike	D11088 efl/gesture: fix zoom to ignore single press events and not crash
Needs Review	zmike	D11087 efl/gesture: restrict flick and momentum gestures to original touch point
Needs Review	zmike	D11086 efl/gesture: handle multi-touch press for tap gestures
Needs Revision	zmike	D11085 efl/gesture: move Point_Data to eo and add methods to fetch it for recognizers
Needs Review	zmike	D11084 tests/gesture: add longpress tests
Needs Review	zmike	D11083 tests/elm: add util functions for pressing mouse button without releasing
Needs Review	zmike	D11082 tests/elm: add util function to automatically delay loop by given time
Accepted	zmike	D11081 efl/gesture: unset timer pointers for tap recognizers
Needs Review	zmike	D11055 tests/gesture: beef up gesture flick/momentum tests significantly
Accepted	zmike	D11054 tests/elm: add util function for dragging the pointer in an arc
Accepted	zmike	D11053 efl/gesture: formatting
Needs Review	zmike	D11052 efl/gesture: correctly handle pointer going off canvas during gestures
Needs Review	zmike	D11029 tests/efl_ui: begin some gesture unit tests
Needs Review	zmike	D11028 tests/elm: add basic timestamping for event helpers
Needs Review	zmike	D11027 efl/gesture: do not emit events for canceled gestures with no state
Closed	zmike	D11026 efl/gesture: correct namespacing of all gesture enums in C

Diff 28267

View Options

src/lib/evas/gesture/efl_canvas_gesture_recognizer_zoom.c