Page MenuHomePhabricator

evas_object_textblock: treat variation sequence as single run
ClosedPublic

Authored by ali.alzyod on Jan 14 2020, 6:23 AM.

Details

Summary

Variation sequence treated as a single run, if we found one, we keep looking adding to the same run, but if it is not, then we need to start a new one.

Before:

After:

Test Plan
#include <stdio.h>
#include <Elementary.h>
/*
gcc -o example test.c `pkg-config --cflags --libs elementary`
*/

EAPI_MAIN int
elm_main(int argc EINA_UNUSED, char **argv EINA_UNUSED)
{
   Evas_Object *win, *en;

   elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);

   win = elm_win_util_standard_add("emoji-example", "emoji-example");
   elm_win_autodel_set(win, EINA_TRUE);

   en = elm_entry_add(win);
   elm_entry_scrollable_set(en, EINA_TRUE);
   evas_object_size_hint_weight_set(en, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
   evas_object_size_hint_align_set(en, EVAS_HINT_FILL, EVAS_HINT_FILL);

   elm_object_text_set(en, "<font_size=25>&#x262a;&#x262a;&#xfe0f;&#x262a;가</font_size>");

   evas_object_show(en);

   elm_object_content_set(win, en);
   evas_object_resize(win, 400, 200);
   evas_object_show(win);

   elm_run();

   return 0;
}
ELM_MAIN()

Diff Detail

Repository
rEFL core/efl
Branch
arcpatch-D11072
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15382
Build 10573: arc lint + arc unit
ali.alzyod created this revision.Jan 14 2020, 6:23 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Jan 14 2020, 6:23 AM
ali.alzyod updated this revision to Diff 28160.Jan 14 2020, 6:29 AM

remove spaces

ali.alzyod edited the summary of this revision. (Show Details)Jan 14 2020, 6:34 AM
ali.alzyod edited the test plan for this revision. (Show Details)

This patch works fine.

The situation where two identical emoji unicodes are represented differently by the font cache in a sentence is confusing to the user.

In that regard, I think this patch is necessary.

woohyun accepted this revision.Jan 22 2020, 11:32 PM
This revision is now accepted and ready to land.Jan 22 2020, 11:32 PM
This revision was automatically updated to reflect the committed changes.