Page MenuHomePhabricator

efl.ui.textbox: part implementation comments clean up!
ClosedPublic

Authored by ali.alzyod on Jan 14 2020, 11:45 PM.

Details

Summary

We did not use the ELM_PART_OVERRIDE_ because it produces compilation error

../src/lib/elementary/efl_ui_textbox.c:3603:40: error: ‘EFL_UI_TEXTBOX_PART_CLASS’ undeclared (first use in this function)
 ELM_PART_OVERRIDE_PARTIAL(efl_ui_text, EFL_UI_TEXTBOX, Efl_Ui_Textbox_Data, _part_is_efl_ui_text_part)

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ali.alzyod created this revision.Jan 14 2020, 11:45 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Jan 14 2020, 11:45 PM
ali.alzyod edited the summary of this revision. (Show Details)Jan 14 2020, 11:47 PM
ali.alzyod added reviewers: woohyun, bu5hm4n.

Mhm - is there a reason the part class is not called Text *box* _Part ?

Mhm - is there a reason the part class is not called Text *box* _Part ?

I have no idea :)

@segfaultxavi Naaaaaaaame discussion, should be the part Efl.Ui.Text_Part be renamed to Efl.Ui.Textbox_Part ?

@bu5hm4n

I think it should be Efl.Ui.Textbox_Part :)

I think so too.

@segfaultxavi @bu5hm4n
D11107 <- for efl_ui_textBOX_part :)

woohyun accepted this revision.Jan 15 2020, 2:40 PM
This revision is now accepted and ready to land.Jan 15 2020, 2:40 PM
This revision was automatically updated to reflect the committed changes.