Page MenuHomePhabricator
Differential D11102

efl.ui.textbox: part implementation comments clean up!
ClosedPublic
Actions

Authored by ali.alzyod on Jan 14 2020, 11:45 PM.

Details

Reviewers
woohyun
bu5hm4n
Maniphest Tasks
T8522: Efl.Ui.Textbox class
Commits
rEFLbbecc6662d3a: efl.ui.textbox: part implementation comments clean up!
Summary

We did not use the ELM_PART_OVERRIDE_ because it produces compilation error

../src/lib/elementary/efl_ui_textbox.c:3603:40: error: ‘EFL_UI_TEXTBOX_PART_CLASS’ undeclared (first use in this function)
 ELM_PART_OVERRIDE_PARTIAL(efl_ui_text, EFL_UI_TEXTBOX, Efl_Ui_Textbox_Data, _part_is_efl_ui_text_part)

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ali.alzyod created this revision.Jan 14 2020, 11:45 PM
Herald added a project: efl. · View Herald TranscriptJan 14 2020, 11:45 PM
Herald added subscribers: committers, reviewers, cedric. · View Herald Transcript

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Jan 14 2020, 11:45 PM
ali.alzyod edited the summary of this revision. (Show Details)Jan 14 2020, 11:47 PM
ali.alzyod added reviewers: woohyun, bu5hm4n.
bu5hm4n added a comment.Jan 14 2020, 11:55 PM

Mhm - is there a reason the part class is not called Text *box* _Part ?

ali.alzyod added a comment.Jan 14 2020, 11:56 PM
In D11102#209875, @bu5hm4n wrote:

Mhm - is there a reason the part class is not called Text *box* _Part ?

I have no idea :)

bu5hm4n added a subscriber: segfaultxavi.Jan 14 2020, 11:59 PM

@segfaultxavi Naaaaaaaame discussion, should be the part Efl.Ui.Text_Part be renamed to Efl.Ui.Textbox_Part ?

woohyun added a comment.Jan 15 2020, 4:15 AM

@bu5hm4n

I think it should be Efl.Ui.Textbox_Part :)

segfaultxavi added a comment.Jan 15 2020, 5:13 AM

I think so too.

woohyun added a comment.Jan 15 2020, 2:40 PM

@segfaultxavi @bu5hm4n
D11107 <- for efl_ui_textBOX_part :)

woohyun accepted this revision.Jan 15 2020, 2:40 PM
This revision is now accepted and ready to land.Jan 15 2020, 2:40 PM
Closed by commit rEFLbbecc6662d3a: efl.ui.textbox: part implementation comments clean up! (authored by ali.alzyod, committed by woohyun). · Explain WhyJan 15 2020, 4:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28203

View Options

src/lib/elementary/efl_ui_textbox.c

Loading...