Code structures like top = elm_widget_top_get(data); and if (efl_isa(top, EFL_UI_WIN_CLASS)) can be replaced with top = efl_provider_find(widget, EFL_UI_WIN_CLASS) No type check needed. (That should enhance the performance)
woohyun bu5hm4n cedric
- Maniphest Tasks
- T8522: Efl.Ui.Textbox class
- rEFL28675d2705e8: efl.ui.textbox: using efl_provider_find
It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/
It is basically fine. However, i think you could also remove the checks for top beeing not NULL. As every widget *must* be able to return theire window object. Otherwise the construction would have failed.