Page MenuHomePhabricator

meson: Changed meson build to support address sanitizer build
Needs ReviewPublic

Authored by smohanty on Jan 20 2020, 6:06 PM.

Details

Summary

As we run some intermediate binary like edje_cc during efl build , and due to
those binary has some memory leaks the address sanitizer build of efl fails.
This Patch runs those binary with 'ASAN_OPTIONS=detect_leak=false' to disable the
memory leak check for those binaries.

Diff Detail

Repository
rEFL core/efl
Branch
asan
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15493
Build 10642: arc lint + arc unit
smohanty created this revision.Jan 20 2020, 6:06 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

smohanty requested review of this revision.Jan 20 2020, 6:06 PM
bu5hm4n added a subscriber: stefan_schmidt.

I think @stefan_schmidt should check this out. He does all the things arround asan.

I think it make sense to have a working build when the address sanitizer option is enabled. Thanks for working on this.
The approach for running asan on the CI infra is to use a suppression file to ignore the known leaks:
https://git.enlightenment.org/core/efl.git/tree/.ci/asan-ignore-leaks.supp
LSAN_OPTIONS=suppressions=/src/.ci/asan-ignore-leaks.supp
This would make sure we will notice new leaks that we might want to check during development.

Not really committed to either of the two approaches. Would you be interested in switching thsi patch to using the ignore file or would you prefer the full leak ignore approach?

zmike added a subscriber: zmike.Wed, Mar 18, 7:11 AM

What's going on here?

From my side I am waiting for feedback from @smohanty

As written before I am fine with the approach as is. If we go the route of disable all leak checks or only suppress the known ones I have no strong opinion.