Page MenuHomePhabricator

efl_ui_spotlight: rename Manager_XXX and Indicator_XXX
ClosedPublic

Authored by Jaehyun_Cho on Jan 21 2020, 3:43 AM.

Details

Summary

In spotlight classes, "Manager" and "Indicator" are used as prefix in
the class names.
e.g. Efl.Ui.Spotlight.Manager_Plain, Efl.Ui.Spotlight.Indicator_Icon

However, those classes are basically manager and indicator classes with
different features. Therefore, "Manager" and "Indicator" should be used
as postfix in the class names.
e.g. Efl.Ui.Spotlight.Plain_Manager, Efl.Ui.Spotlight.Icon_Indicator

However, for the easier usage of C APIs, c_prefix of those classes are
remained to be "efl_ui_spotlight_manager_xxx" and
"efl_ui_spotlight_indicator_xxx".

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Jaehyun_Cho created this revision.Jan 21 2020, 3:43 AM
Jaehyun_Cho requested review of this revision.Jan 21 2020, 3:43 AM

Is it OK if this patch is submitted?

We could discuss forever which one makes more "sense", but this rename is consistent with the latest renames we have been doing so it looks good to me. @bu5hm4n ?

To be honest, after renaming this whole thing 3 times, i do not really care anymore, so i am fine with whatever name is choosen.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 22 2020, 8:01 PM
This revision was automatically updated to reflect the committed changes.